keyring icon indicating copy to clipboard operation
keyring copied to clipboard

Connection avatar downgraded to HTTP

Open ChaosExAnima opened this issue 5 years ago • 0 comments

This is related to #17 and #18. The code to display connection avatars uses set_url_scheme, which changes the scheme based off of the current site configuration. However, in many cases that would mean that the avatar is downgraded to HTTP when HTTPS is available, or even in the case of Google's avatars where a non-SSL version is not available.

I would propose instead that the following logic:

  • If the avatar is HTTPS, keep the URL unchanged.
  • If the avatar is HTTP, add a filter or other method to allow services to declare SSL should be forced. If this is set to true, set the schema to HTTPS.
  • If the service did not opt in, use the current logic.

Happy to contribute a PR if desired.

ChaosExAnima avatar Sep 11 '19 16:09 ChaosExAnima