codeowners icon indicating copy to clipboard operation
codeowners copied to clipboard

Feature Request: Flag to ignore files in .gitignore

Open silviorp opened this issue 1 year ago • 4 comments

A great feature would be having the option to filter out all the files that are included in the .gitignore.

Something like:

codeowners audit --unowned --no-ignored

silviorp avatar Dec 14 '23 17:12 silviorp

We're looking to adopt this as part of a pre-commit workflow and we'd need this for things to work appropriately. Would love to see this one added @beaugunderson !

vincentjames501 avatar Jul 15 '24 22:07 vincentjames501

will look at this tonight—would also love some maintenance help if either of you are up for it!

On Mon, Jul 15 2024 at 17:21, Vincent Pizzo @.***> wrote:

We're looking to adopt this as part of a pre-commit workflow and we'd need this for things to work appropriately. Would love to see this one added @beaugunderson https://github.com/beaugunderson !

— Reply to this email directly, view it on GitHub https://github.com/beaugunderson/codeowners/issues/38#issuecomment-2229535186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAPCX7L5F6FBSVY5QO4HKDZMRDPNAVCNFSM6AAAAABK5MPGFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRZGUZTKMJYGY . You are receiving this because you were mentioned.Message ID: @.***>

beaugunderson avatar Jul 15 '24 22:07 beaugunderson

@vincentjames501 can you pull this PR locally, npm link, and run it against your repo to see if it works for you? https://github.com/beaugunderson/codeowners/pull/43

I implemented it so that .gitignore is used by default and you have to specify a flag if you want it NOT used

beaugunderson avatar Jul 15 '24 23:07 beaugunderson

tested #43 and it works if it is a single .gitignore at the root - i don't think it currently takes into account nested .gitignore files though^

aranair avatar Sep 05 '24 13:09 aranair