Daniel Kraus

Results 101 comments of Daniel Kraus

To move on with this PR, how about excluding the update of the experimental Java version (i.e. Java 19)? I would create separate issue(s) for: * Let the default locale...

Created #658 and #659, and set experimental Java version to 18.

Now the tests appear to "truly" run on the module path if we pass `modularBuild=true`. The project uses a separate `src/test/module/module-info.java` for this, including a bunch of "hacks". 8 remaining...

(Almost) all builds are green! ![grafik](https://user-images.githubusercontent.com/11643714/188512331-28cfaa15-f309-48a9-b551-c9679fb0c921.png) (That [episode](https://imdb.com/title/tt0775573/) deserves a better rating!) --- Jokes aside: * The 2 failing experimental builds complain about: ```text No compatible toolchains found for request...

@aepfli thx for the fix! One more thing: https://github.com/junit-pioneer/junit-pioneer/blob/e68e91d40d2e9ac862229a9a34bc861b5d402699/.github/workflows/build.yml#L155 https://github.com/junit-pioneer/junit-pioneer/blob/e68e91d40d2e9ac862229a9a34bc861b5d402699/.github/workflows/build.yml#L170 I find these comments a bit confusing, both mention "execution" but use different Java version. Maybe: ``` # Gradle doesn't...

#611 improved the GHA build, but didn't address the lack of feedback mentioned in this issue, therefore, reopened.

While I'm here: the new job summary feature might be helpful. https://github.blog/changelog/2022-05-09-github-actions-enhance-your-actions-with-job-summaries/

Please follow that thread: https://twitter.com/beatngu1101/status/1407008608118771717 Do you have another idea? Otherwise, I would close this issue.

Yes, the token _shouldn't_ be public. We already voted for the analysis of external PRs, but until then we have three options: 1. Skip SonarCloud analysis 2. Failing SonarCloud analysis...