Daniel Kraus
Daniel Kraus
Hey @JoergSiebahn, thank you for the detailed issue description! 🙏 [We actually considered this a bug](https://github.com/junit-pioneer/junit-pioneer/issues/479#issuecomment-1078361099), but your use case is definitely valid. We will look into this and try...
Due to our new reset mechanism, I think we can no longer combine `BeforeEach`/`BeforeAll`. But as @Michael1993 said, we could provide a configuration option: ```java @TestMethodOrder(OrderAnnotation.class) // Default execution phase...
Let's recall your comment [here](https://github.com/junit-pioneer/junit-pioneer/issues/479#issuecomment-990109197): >Assume the extension sets a global state (say, a system property or default locale) before and then resets the former state after. > >* If...
After today's maintainer meeting: we would first try to keep the current/new behavior, but make the extension additionally visible in `@BeforeAll`. That is: ```java @TestMethodOrder(OrderAnnotation.class) @SetSystemProperty(key = "foo", value =...
Hi @JoergSiebahn, thanks for the feedback! 👍 So, we will first follow the aforementioned approach, where we "try to keep the current/new behavior, but make the extension additionally visible in...
Related (via https://github.com/junit-pioneer/junit-pioneer/issues/381#issuecomment-1001221833): https://github.com/apache/logging-log4j2/pull/658#issuecomment-1001159235
> **Warning** > Added `merge-ready` to see how the build behaves.
JUnit 5.9.0-RC1 is causing trouble: ```text /home/runner/work/junit-pioneer/junit-pioneer/src/test/java/org/junitpioneer/internal/TestExtensionContext.java:33: error: TestExtensionContext is not abstract and does not override abstract method getExecutableInvoker() in ExtensionContext public class TestExtensionContext implements ExtensionContext { ``` Will exclude...
I believe it is because of this: https://github.com/junit-pioneer/junit-pioneer/blob/main/docs/environment-variables.adoc#warnings-for-reflective-access But why are tests passing on 17? Shouldn't the `InaccessibleObjectException` also occur there? https://github.com/junit-pioneer/junit-pioneer/runs/6745721032?check_suite_focus=true#step:4:66
Now we get an error in the default locale extension with Java 19: ```text > Task :compileJava D:\a\junit-pioneer\junit-pioneer\src\main\java\org\junitpioneer\jupiter\DefaultLocaleExtension.java:69: warning: [deprecation] Locale(String,String,String) in Locale has been deprecated return new Locale(language, country,...