beartype
feat: Mypy config
Hmm. Not sure what changed with python check_linter_assertions.py tests/typechecked.
@nstarman The error says that the script expected mypy to throw an error saying
no overload variant of "f" matches argument type "float"
but mypy didn’t. If you run mypy on test_overload.py, do you see that error? Maybe the additional type hints changed mypys error.
Plz don't squash.
Ah, you not like to squash and merge? Would you prefer another way?
I normally like Squash & Merge, but for this PR I was trying to keep each commit a distinct contribution: the configuration, then adding typing to each module. You can Squash & Merge, of course, I was just suggesting that for this PR a normal merge was appropriate.
@nstarman Ah, that makes total sense! Thanks for the explanation. I’m also happy to merge without squashing if the commits are nicely structured. I don’t feel strongly any particular way. :)
Pull Request Test Coverage Report for Build 20034182925
Details
- 82 of 82 (100.0%) changed or added relevant lines in 10 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.004%) to 99.617%
| Totals | |
|---|---|
| Change from base Build 20020049541: | 0.004% |
| Covered Lines: | 1301 |
| Relevant Lines: | 1306 |
