plum icon indicating copy to clipboard operation
plum copied to clipboard

Use `codspeed` for benchmarks

Open nstarman opened this issue 1 year ago • 8 comments

https://codspeed.io.

I'd be interested to see bottlenecks and would probably contribute speed-optimization PRs.

nstarman avatar Apr 21 '24 17:04 nstarman

@nstarman Will do! Will report back here when that's enabled.

wesselb avatar Apr 25 '24 20:04 wesselb

@leycec, would you be OK with using https://codspeed.io for Plum? I've attempted to add beartype/plum to https://codspeed.io, and there should be a request for you to accept or deny. :)

wesselb avatar Jul 06 '24 08:07 wesselb

Superbness. I'll immediately make it so. Tangentially, I've also been meaning to:

  • Escalate your @beartype org privileges to co-Admin. Every repo benefits from multiple Admins, right? What do you say? Wanna be a @beartype org Admin? Then you won't need to ping me anymore. You'll be free to go ham and wreak havoc as if GitHub was your own private demolition derby. This also helps the @beartype community to avoid force majeure-style cataclysmic events like Ontario becoming Province Zero for the inevitable Sophon alien invasion. ...wait. the Sophons are just proteins folded into hyper-dimensional supercomputers? laaame.
  • Announce a new beartype/bearden repo to discuss @beartype org-wide issues like this.

None of that's happened yet. Thrash me in a month if I still haven't done any of that. :face_holding_back_tears:

leycec avatar Jul 06 '24 23:07 leycec

What do you say?

Whoa, yes, this would be amazing. :) Of course I will promise to use my very best judgement when exercising co-admin powers! Coincidentally it seems that I can't quite yet configure Codspeed because I'm missing some permissions, so that would solve that too.

Announce a new beartype/bearden repo to discuss https://github.com/beartype org-wide issues like this.

Aha! Great idea. :) I like it!

wesselb avatar Jul 09 '24 11:07 wesselb

Welcome! Welcome to your new-found superpowers. I am your Bear Father, @leycec. NOOOOOOOOOOOO—

There are only Two Rules to Bear Club. It's a small club and we're it:

  1. Please avoid promoting anybody else to the status of "Owner" in the @beartype organization. I trust you implicitly. You are @wesselb, a well-known force of goodness. I don't necessarily trust anyone else implicitly, however. Rule One of Bear Club has a little-known Sub-Rule...
    1. Please do feel free to promote anybody you like to the status of "Member" in the @beartype organization. Members are totally fine, right? Their destructive superpowers are limited. Everybody likes members. ...gods. the puns just write themselves tonight.
  2. Please avoid probing the beartype/beartype repository. Please feel free to probe any other repository. The beartype/beartype repository, however, is the ultimate sacred space – where even sanctity itself goes to chill out and take a rest in the hot tub. It's will is inviolable and sacrosanct. Please don't destroy beartype/beartype. I beg this of you! Amsterdam itself depends upon this.

That is all. Thus spake your Bear Father, @leycec. NOOOOOOOOOOOO—

leycec avatar Jul 10 '24 06:07 leycec

@leycec yesssssssssss, that's amazing. Thank you for your trust! :) I will be very sure to avoid promoting anyeone else to the status of owner. I will also be very sure to not touch beartype/beartype. In fact, I will only touch beartype/plum unless there is a very good reason. Whooo!

wesselb avatar Jul 12 '24 13:07 wesselb

@nstarman The CodSpeed GitHub app is installed and has read access to beartype/plum. Strangely enough I can't see Plum appearing on codspeed.io:

image

Clicking import then takes me to this page:

image

And clicking configure then shows that the CodSpeed app already has access to beartype/plum.

Maybe the repo will appear automatically after the first benchmarks have been run.

wesselb avatar Jul 12 '24 13:07 wesselb

Maybe the repo will appear automatically after the first benchmarks have been run.

Makes sense!

nstarman avatar Jul 12 '24 14:07 nstarman