Barrett Strausser
Barrett Strausser
Can be closed by linked issue.
I haven't contributed before, I can grab this if thats okay.
Just so I can confirm scope 1. I see that the other exporters all take a `featureEvents []exporter.FeatureEvent`. This needs to be converted into a trace. I need to learn...
@purpleidea Can you assign this to me. I'm basically just go to port what is done in https://github.com/systemd/systemd/blob/main/src/basic/virt.c#L674 I'm going to start with Docker, Podman, EC2 and GCE
Are lists supported in a HashModels? I always assumed based on docs they are not. https://github.com/redis/redis-om-python/blob/main/docs/models.md#hashmodel-vs-jsonmodel
@xtonik If you are still working on this - You can look at what I did in the recent go release. https://github.com/RoaringBitmap/roaring/blob/master/roaring_test.go#L2681 You'll need to understand the serialization protocol, but...
It looks like what is happening is a concurrent write to the webscocket connection https://github.com/thomaspoignant/go-feature-flag/blob/main/cmd/relayproxy/controller/ws_flag_change.go#L87 and https://github.com/thomaspoignant/go-feature-flag/blob/main/cmd/relayproxy/service/websocket.go#L45 ``` ================== WARNING: DATA RACE Read at 0x00c0001f0338 by goroutine 32: github.com/gorilla/websocket.(*Conn).beginMessage() /home/bstrausser/go/pkg/mod/github.com/gorilla/[email protected]/conn.go:492...
@thomaspoignant Can you let me know what you think of this? Since the `Value` on `FeatureEvent` is an `interface` it was a bit tricky to get in as a set...
> I am sorry to be slow on the review. I will do it very soon. No problem. Life exists outside github!
@thomaspoignant Anything else on this? I'm going on holiday and am closing out my open pr's