openWAR icon indicating copy to clipboard operation
openWAR copied to clipboard

getData Error

Open gjm112 opened this issue 7 years ago • 1 comments

ds = getData(start = "2013-06-30")

Retrieving data from 2013-06-30 ...

...found 0 games

Error in grouped_df_impl(data, unname(vars), drop) : Column gameId is unknown

So the update by znmeb fixes part of this, but now I get:

ds = getData(start = "2018-04-01")

Retrieving data from 2018-04-01 ...

...found 13 games

day_01/gid_2018_04_01_anamlb_o day_01/gid_2018_04_01_bosmlb_t day_01/gid_2018_04_01_chamlb_k day_01/gid_2018_04_01_chnmlb_m day_01/gid_2018_04_01_clemlb_s day_01/gid_2018_04_01_houmlb_t day_01/gid_2018_04_01_minmlb_b day_01/gid_2018_04_01_nyamlb_t day_01/gid_2018_04_01_pitmlb_d day_01/gid_2018_04_01_pitmlb_d day_01/gid_2018_04_01_sfnmlb_l day_01/gid_2018_04_01_slnmlb_n day_01/gid_2018_04_01_wasmlb_c Error in grouped_df_impl(data, unname(vars), drop) : Column gameId is unknown

gjm112 avatar Apr 03 '18 04:04 gjm112

This is an issue because the mlb api changed to include the day_xx portion of the url in their gameIds. I've got it fixed in this pull request https://github.com/beanumber/openWAR/pull/114

james-ingold avatar Apr 03 '18 15:04 james-ingold