beancount
feat: add fortnightly interval
In some countries (such as Australia), it is very common for wages to be paid on a fortnightly basis, that is, every 2 weeks. As a result, a number of other expenses are also paid on a fortnightly basis.
This commit extends the Interval enum by adding a FORTNIGHT option. I have added a test for that, and have updated the translations where possible (not that other than for English and French, the other translations may be suboptimal).
~As part of this commit, I have also taken the opportunity to fix a confusion between ISO weeks and calendar weeks as the two do not always match, and 2025-W01 is the ISO format indicating the week starting on December 30 2024. Let me know if you want me to split out this particular change into a separate PR.~ EDIT: I have moved this into #1956.
Resolves: #1939
I have updated the tests to ensure 100% test coverage. I did have to add to lines with # pragma nocover because they should be unreachable.
For the coverage, would you be open to a PR adding integration with Codecov? This will help see coverage of PRs automatically, and it is free for OSS projects. You can see an example of how Codecov integrates within GitHub at:
https://github.com/pact-foundation/pact-python/pull/935
And you can follow links therein to see the more detailed coverage reports.
For the coverage, would you be open to a PR adding integration with Codecov? This will help see coverage of PRs automatically, and it is free for OSS projects.
Thanks, but no thanks for now. In another project (lektor/lektor) there's been a lot of churn to get codecov to work again after some breaking changes to their actions and it's still not working. I don't see that codecov adds enough value to warrant these efforts to keep it working (in particular if it's a cloud-only proprietary tool, I'd rather focus on open source tools that can be run locally). In #2001 I've added a tox build in CI to test for full coverage.
I'm on holidays at the moment, so I'll get back to this PR when I'm back 🙂