beancount
Add dark/light mode switch buttons in Options menu
Solve these 2 issues:
https://github.com/beancount/fava/pull/1883 https://github.com/beancount/fava/issues/1874
Descriptiopn
The website style can now be manually set by going to Options in the side bar menu and selecting one of the 3 options
-
System -
Light -
Dark
Screenshot
@Adoliin, thanks for the code! Would be awesome to get this in at some point.
FWIW, I've also tested this together with fava-dashboards. It needs some changes to the library like https://github.com/Evernight/fava-dashboards/commit/9872223222039fa02690d7170d721b4c96fd549e but works well after that.
Didn't get a chance to try https://github.com/beancount/fava/pull/1883 before. Personally, I think a tidy single icon (not a toggle) next to the filters could be well-fitting as well but switch in the options works nicely too (imo).
Not qualified to comment on CSS changes though.
@Evernight, Thanks, just let me know what issue this PR is causing with fava-dashboards
@yagebu, I just wanted to follow up on this PR. It's been a month since submission, and I wanted to check if there's anything I can do to help move it forward. Please let me know if any changes are needed. Thanks :)
@Evernight, Thanks, just let me know what issue this PR is causing with fava-dashboards
@Adoliin , I already have a fix ready, just in case: https://github.com/andreasgerstmayr/fava-dashboards/compare/main...Evernight:fava-dashboards:fava-theme-switch
It's basically replacing the selector in css, identical to your changes, and also adjusting the JS logic a little bit.
By the way, I have patched versions of Fava and dashboards with the switch running together in more recent versions of https://github.com/Evernight/lazy-beancount since I really needed the ability to switch between themes.