fava icon indicating copy to clipboard operation
fava copied to clipboard

When using Filter, Balance/Changes screen should not show accounts which have zero value because of the filter

Open prafullat opened this issue 5 years ago • 6 comments

See this URL for example: https://fava.pythonanywhere.com/huge-example-file/account/Expenses/balances/?filter=payee%3A%22Uncle+Boons%22

Uncle Boons filter is showing values for only Food and Restaurant, If we skip showing other accounts, it would be better.

prafullat avatar May 26 '20 11:05 prafullat

There's an option for that: show-accounts-with-zero-balance

yagebu avatar May 27 '20 17:05 yagebu

I used both of the following options, but it still showed empty accounts on balance/changes screen ( above URL)

1970-01-01 custom "fava-option" "show-accounts-with-zero-balance" "false"
1970-01-01 custom "fava-option" "show-accounts-with-zero-transactions" "false"

prafullat avatar May 29 '20 13:05 prafullat

You're quite right. These options are currently not respected in the balance and change account trees. A PR fixing that would be welcome.

yagebu avatar May 30 '20 08:05 yagebu

Ok, I would like to help with it. Can you please assign it to me?

prafullat avatar May 30 '20 13:05 prafullat

Hi, It looks like, it started working now. Not sure what has changed, but I do not see accounts which are zero or no transactions. Can you please confirm if any recent changes fix it?

prafullat avatar Jun 02 '20 15:06 prafullat

Added a fix in this PR : https://github.com/beancount/fava/pull/1118 Please take a look

prafullat avatar Jun 06 '20 17:06 prafullat

I used both of the following options, but it still showed empty accounts on balance/changes screen ( above URL)

1970-01-01 custom "fava-option" "show-accounts-with-zero-balance" "false"
1970-01-01 custom "fava-option" "show-accounts-with-zero-transactions" "false"

hello mate, tried above lines on June 2023 ,Fava version 1.23.x it works well on my end

maybe someone fix the issues ?

xiaoyuesansui avatar Jun 25 '23 05:06 xiaoyuesansui

This will be fixed by #1664

yagebu avatar Aug 27 '23 09:08 yagebu