beangulp icon indicating copy to clipboard operation
beangulp copied to clipboard

Ignore entries without amount in amount_map

Open henrikssn opened this issue 3 years ago • 2 comments

Fixes #98

henrikssn avatar Jan 17 '22 15:01 henrikssn

This avoids the exception that is otherwise raised when a MISSING value is encountered, however, I suspect that with this change the similarity comparison would be unable to match transactions with posting with missing values. Adding a test case for this would be very helpful.

dnicolodi avatar Jan 17 '22 19:01 dnicolodi

This avoids the exception that is otherwise raised when a MISSING value is encountered, however, I suspect that with this change the similarity comparison would be unable to match transactions with posting with missing values. Adding a test case for this would be very helpful.

Yeah, I think you are right... Would a better solution be to store an (account, key): None entry in the map?

henrikssn avatar Jan 17 '22 20:01 henrikssn