telemetry_metrics icon indicating copy to clipboard operation
telemetry_metrics copied to clipboard

Exemplars

Open isaacsanders opened this issue 3 years ago • 2 comments

I'm thinking about exemplars lately. If the set of labels that generate exemplars is just another list in the reporter_opts, this library doesn't need to change.

Are there any thoughts on that?

isaacsanders avatar Dec 16 '21 20:12 isaacsanders

If the set of labels that generate exemplars is just another list in the reporter_opts, this library doesn't need to change.

It sounds like this is the way to go?

josevalim avatar Dec 16 '21 20:12 josevalim

Yeah, that sounds like the right approach.

arkgil avatar Dec 21 '21 13:12 arkgil

Here is a PR that implements exemplars for Prometheus: https://github.com/beam-telemetry/telemetry_metrics_prometheus_core/pull/54

isaacsanders avatar Feb 17 '23 21:02 isaacsanders

@josevalim Can you point to there this was completed?

isaacsanders avatar Jan 11 '24 15:01 isaacsanders

It is not an issue with this library. It goes to reporter_options, as you have described. I guess I could have used the other close command, I am still getting used to that. :)

josevalim avatar Jan 11 '24 16:01 josevalim