stripity-stripe icon indicating copy to clipboard operation
stripity-stripe copied to clipboard

Published 20 hours ago • verified publisher icon beam-community

Add destination_balance to Topup

Open jfpedroza opened this issue 2 years ago • 6 comments

Adds the destionation_balance field to Topup. This field is in preview so I don't know if the PR can be merged yet.

The test I added doesn't pass because Stripe Mock doesn't recognize the field. I tested the functions against a real account and it works properly. I could delete the test so it can be merged.

jfpedroza avatar Apr 22 '22 05:04 jfpedroza

@johnf9896 Mind merging master and see if the bump to stripe mock fixes it?

snewcomer avatar May 06 '22 01:05 snewcomer

It still doesn't pass.

jfpedroza avatar May 06 '22 03:05 jfpedroza

@johnf9896 Mind pointing me to the docs where this API parameter is listed? I can't find it

https://stripe.com/docs/api/topups/create

snewcomer avatar May 29 '22 12:05 snewcomer

@snewcomer It seems it's only visible if you are logged in and your account has access to the feature:

image

jfpedroza avatar May 30 '22 23:05 jfpedroza

Ok. Well, it looks like one test for topup is failing. Does it pass for you locally?

Screen Shot 2022-06-17 at 9 48 29 PM

snewcomer avatar Jun 18 '22 02:06 snewcomer

No, it doesn't pass. I know the change works because we are already using it against a real Stripe account but Stripe Mock won't recognize the field.

jfpedroza avatar Jun 20 '22 03:06 jfpedroza