stripity-stripe icon indicating copy to clipboard operation
stripity-stripe copied to clipboard

feat: don't load webhook plug if plug isn't part of the loaded apps

Open MikaAK opened this issue 2 years ago • 2 comments

Currently we cannot compile stripity_stripe anymore due to this error after upgrading to elixir 1.12 (application boundary crossing)

[info] Application plug_crypto exited: exited in: Plug.Crypto.Application.start(:normal, [])
    ** (EXIT) an exception was raised:
        ** (UndefinedFunctionError) function Plug.Crypto.Application.start/2 is undefined (module Plug.Crypto.Application is not available)
            (plug_crypto 1.2.2) Plug.Crypto.Application.start(:normal, [])
            (kernel 8.1.2) application_master.erl:293: :application_master.start_it_old/4

This PR changes the stripe webhook plug to only load if the current application has plug loaded

MikaAK avatar Dec 01 '21 02:12 MikaAK

@MikaAK Do you have any interest in bringing in the latest master and we can see if we can get this PR's tests passing?

snewcomer avatar May 30 '22 02:05 snewcomer

Done @snewcomer Tests won't run because they need approval from a maintainer

MikaAK avatar Jun 06 '22 20:06 MikaAK

@MikaAK Can we bring in master one more time?

snewcomer avatar Oct 03 '22 02:10 snewcomer

Sorry @snewcomer , I've done this quite a few times, I think it's best someone else does it at this point!!

MikaAK avatar Oct 03 '22 08:10 MikaAK