jsonapi icon indicating copy to clipboard operation
jsonapi copied to clipboard

Published 20 hours ago • verified publisher icon beam-community

Add c:JSONAPI.View.get_field/3

Open whatyouhide opened this issue 3 years ago • 1 comments

Closes https://github.com/beam-community/jsonapi/issues/272.

whatyouhide avatar Sep 20 '22 19:09 whatyouhide

Ping @davydog187 and/or @doomspork? 🙃

whatyouhide avatar Sep 30 '22 07:09 whatyouhide

@doomspork Would you be interested in having me help maintain (review and/or release) this project? I'm very interesting in chipping in more formally and keeping momentum up. Sorry, I feel a comment on a PR is a terrible place to make that plea, I've just had trouble finding a better way to reach out!

mattpolzin avatar Nov 23 '22 16:11 mattpolzin

@whatyouhide do you mind merging the main branch into yours again to see if GitHub will recognize that it hasn't run CI against this branch yet? I now have the ability to merge this PR once we figure out why GitHub has forgotten that there are CI actions to run against it!

mattpolzin avatar Dec 27 '22 21:12 mattpolzin

@mattpolzin you'll need to re-approve as well 👍

doomspork avatar Dec 27 '22 21:12 doomspork

@mattpolzin just rebased on master and pushed.

whatyouhide avatar Dec 28 '22 08:12 whatyouhide

Thank you! I am fixing CI over here so I'll have you merge once more after that lands. Appreciate your patience!

mattpolzin avatar Dec 28 '22 15:12 mattpolzin

Ok, that's sorted when you get the chance to merge master in again @whatyouhide .

mattpolzin avatar Dec 28 '22 15:12 mattpolzin

Sorry all, just catching up here. Let me know if I can help @whatyouhide @mattpolzin

davydog187 avatar Dec 28 '22 16:12 davydog187

Updated the branch protections which should now allow us to update a branch to master 👍 Just did so here and it has kicked off CI.

doomspork avatar Dec 28 '22 17:12 doomspork