elixir-companies icon indicating copy to clipboard operation
elixir-companies copied to clipboard
verified publisher icon beam-community

Update `get_company!` to work without Ecto

Open doomspork opened this issue 2 years ago • 3 comments

https://github.com/beam-community/elixir-companies/blob/main/lib/companies/companies.ex#L55-L71

doomspork avatar Mar 04 '23 21:03 doomspork

Hi, is this func used for query+update company profile? If yes, I think the id should be related to company files name in priv/companies.

vvuunnqq avatar Mar 13 '23 13:03 vvuunnqq

Howdy @vvuunnqq! We don't allow updating companies via the site at this point so that usage is no longer necessary. I believe this is only used when we use the show route for a company.

If yes, I think the id should be related to company files name in priv/companies.

Agreed! Happy to yield to you here. We did discuss slugs before: https://github.com/beam-community/elixir-companies/issues/588

doomspork avatar Mar 13 '23 15:03 doomspork

hmmm, I'm not sure at all, just create a PR #679 to support url slug 😁

vvuunnqq avatar Mar 14 '23 14:03 vvuunnqq