bamboo icon indicating copy to clipboard operation
bamboo copied to clipboard

feat: Add arbitrary header overrides for attachments

Open jarrodmoldrich opened this issue 4 years ago • 3 comments

This allows bamboo adapters to be accept overriding headers for special use cases. Updates to those adapters would be required to use this functionality.

For e.g., in the specific use-case of adding inlined attachments, some special case headers are required. Now it's possible to add X-Attachment-Id and override the Content-Disposition header with inline to permit the proper display of inlined content, without an email client showing them as explicit attachments for the user to download.

Closes #502 #430

Related PRs: https://github.com/kalys/bamboo_ses/pull/43 https://github.com/DockYard/elixir-mail/pull/137

jarrodmoldrich avatar Oct 22 '21 13:10 jarrodmoldrich

Hi @jarrodmoldrich! Now that BEAM Community is taking over Bamboo we're working through these older PRs. Would you like to update this PR or should we close?

doomspork avatar Sep 26 '24 16:09 doomspork

@doomspork Hi there! I probably won't be testing this against SES as I've retired the infra I was using, but I'll get the PR up-to-date and to a working state in the coming weeks.

jarrodmoldrich avatar Sep 26 '24 21:09 jarrodmoldrich

Amazing, thank you @jarrodmoldrich!

doomspork avatar Sep 30 '24 16:09 doomspork

@doomspork This is ready for another look (assuming it passes your CI)

jarrodmoldrich avatar Nov 16 '24 06:11 jarrodmoldrich

This pull request has been automatically marked as "stale:discard". If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated!.

github-actions[bot] avatar Jan 16 '25 01:01 github-actions[bot]

@doomspork Has this work been deprecated? I did update the PR but received no feedback on it.

jarrodmoldrich avatar Jan 16 '25 04:01 jarrodmoldrich