David Beal

Results 124 comments of David Beal

Please could you edit PR name, thanks for this work

Please could you rebase ? @mathieudelva to be mergeable

The name of this module is now https://github.com/OCA/partner-contact/tree/16.0/partner_address_split

Campaign is not related to this module

Hi @rousseldenis thanks for the review, sad to need to use `simple` in this module. As I can see, previous product_seasonality merge `seasonality` "seasonal.config" and kind of `campaign like` "seasonal.config.line"...

Hi @rousseldenis all updates are done. We can probably merge ? Thanks cc @legalsylvain

yes product_app could be nice, thanks

After Contacts app, Catalog sounds nice

@legalsylvain `catalog` also embrace more concepts than just `product_any_string` and is an attractive name that can be extended `catalog_other_feature` better than `product_management_other_feature` IMO

Arf https://medium.com/the-product-marketer/the-art-of-feature-naming-four-survival-tips-76bd86f82cff 1. Keep names simple. A name `doesn’t have to explain everything` about a product. It’s simply a `bookmark` for a concept. 2. Anchor as much as possible to...