ulauncher-windows-switcher icon indicating copy to clipboard operation
ulauncher-windows-switcher copied to clipboard

Published 20 hours ago • verified publisher icon beajeanm

chore: refactor and fix window activation feature

Open Cercedo opened this issue 1 year ago • 6 comments

📌️ Task

  • [x] Add development settings.
  • [x] Refactor main.py using black, isort and pycln.
  • [x] Fix activating target windows.
    • Update *.activate(int(time.time)) with *.activate(0).
  • [x] Update the extension logo.
  • [x] Update the README.md

😃️ Notes

This is my first time making a contribution in a public repo. I'd make some changes but feel free to used it if it's required. Thanks for the extension.

Cercedo avatar Jul 02 '23 07:07 Cercedo

@Cercedo To be honest I haven't used ulauncher or this plugin in years. The changes you've done here look sensible and will probably be an improvement but I don't think I should be the one maintaining this code base anymore.

If you feel like taking over, I suggest that you publish your version on the ulauncher plugin systems, and I will update the description of this plugin to redirect people your way. (A plugin github url cannot be changed, so I can't just transfer the current plugin page to you.)

Hope that helps.

beajeanm avatar Jul 05 '23 12:07 beajeanm

Hi @beajeanm

That sounds great. I will consider to do that. Thank you. :mechanical_arm:

Cercedo avatar Jul 06 '23 03:07 Cercedo

Ok, cool, let me know when your plugin is up so I can update the description of this one and the README of the repo.

beajeanm avatar Jul 07 '23 15:07 beajeanm

Thank you so much. I will. :mechanical_arm:

Cercedo avatar Jul 21 '23 15:07 Cercedo

Really excited about the new plugin refresh! :grinning:

Base-115 avatar Jul 30 '23 23:07 Base-115

Hi Jean

I hope you are well 😃. I'm so sorry for not being in contact for a long time. Thank you so much for the consideration about the extension suggestion. Nonetheless, I would like to keep it as PR.

Have a great day.

On Sun, 30 Jul 2023 at 18:35, Base-115 @.***> wrote:

Really excited about the new plugin refresh! 😀

— Reply to this email directly, view it on GitHub https://github.com/beajeanm/ulauncher-windows-switcher/pull/9#issuecomment-1657294866, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARE5YWZ7EEWV2BDVGZNWNE3XS3VVHANCNFSM6AAAAAAZ3JBKWY . You are receiving this because you were mentioned.Message ID: @.***>

Cercedo avatar Nov 06 '23 14:11 Cercedo