lumberjack icon indicating copy to clipboard operation
lumberjack copied to clipboard

SizeRollingLogFile.flush raises NameError if no max_size is set

Open dirkbolte opened this issue 11 years ago • 0 comments

The following code results in a NameError:

require 'lumberjack'
Lumberjack::Device::SizeRollingLogFile.new('test.log').flush

Backtrace:

from /home/dirkbolte/.rvm/gems/ruby-1.9.3-p392/gems/lumberjack-1.0.4/lib/lumberjack/device/size_rolling_log_file.rb:40:in `>'
    from /home/dirkbolte/.rvm/gems/ruby-1.9.3-p392/gems/lumberjack-1.0.4/lib/lumberjack/device/size_rolling_log_file.rb:40:in `roll_file?'
    from /home/dirkbolte/.rvm/gems/ruby-1.9.3-p392/gems/lumberjack-1.0.4/lib/lumberjack/device/rolling_log_file.rb:46:in `before_flush'
    from /home/dirkbolte/.rvm/gems/ruby-1.9.3-p392/gems/lumberjack-1.0.4/lib/lumberjack/device/writer.rb:95:in `block in flush'
    from :10:in `synchronize'
    from /home/dirkbolte/.rvm/gems/ruby-1.9.3-p392/gems/lumberjack-1.0.4/lib/lumberjack/device/writer.rb:94:in `flush'
    from (irb):3
    from /home/dirkbolte/.rvm/rubies/ruby-1.9.3-p392/bin/irb:13:in `
'

I would expect to either have initialize throw an exception if max_size is not set or to have the other functions work with nil.

dirkbolte avatar Aug 29 '13 07:08 dirkbolte