ndmf icon indicating copy to clipboard operation
ndmf copied to clipboard
verified publisher icon bdunderscore

Improve RuntimeUtil.IsAvatarRoot()

Open kaikoga opened this issue 2 years ago • 0 comments

https://github.com/bdunderscore/ndmf/blob/2d0357f11f2dda7f6894d90b105f6b16fc73675c/Runtime/RuntimeUtil.cs#L95-L105

as-is

  • VRCSDK project: true for VRC avatars, false for non-VRC avatars
  • non-VRCSDK project: true for VRC and non-VRC avatars

to-be

  • VRCSDK projects should be able to handle non-VRC avatars, but not lenient enough to treat all Animators as avatars
  • Something like...?
    • If any avatar platform is detected (for example, VRCSDK and/or uniVRM), iterate through all platform specific checks
    • Else, fallback to Animator heuristic (current non-VRC implementation)

kaikoga avatar Oct 23 '23 18:10 kaikoga