modular-avatar icon indicating copy to clipboard operation
modular-avatar copied to clipboard

Add MA Merge VRM1 SpringBones

Open kaikoga opened this issue 1 year ago • 2 comments

Discussion: https://github.com/bdunderscore/modular-avatar/discussions/467 Merge base PR first: UniVRM components support #569

image

This PR introduces MA Merge VRM1 SpringBones component, which adds SpringBone entries to VRM10Instance. This component does nothing when the target avatar is not VRM1.

I think there is nothing specific to this component that requires localization. Perhaps there could be some warning like "This component is ignored; supports VRM1 avatar only", but many other components that targets VRCSDK only have similar issue.

I have not yet added documents. Merging this PR reveals UniVRM support to end users, so documentation would block the next release once this PR is merged. I don't know yet where to add documents. (It would be under docs~/, but I worry that throwing VRM specific components into the Component reference section makes little sense to VRC users, when the entire components list is even more growing).

kaikoga avatar Dec 30 '23 04:12 kaikoga

ありがとうございます!この辺見れるのは1月中旬になるので少々お待ちください

bdunderscore avatar Dec 31 '23 06:12 bdunderscore

SpringBonesなどについては、クロスプラットフォーム対応に向けて要検討です・・・VRC+VRM+Resoniteで三重設定するのは避けたいので、何かのプリセット的な何かがあったほうがいい気がするんだよね・・・

bdunderscore avatar Aug 20 '24 03:08 bdunderscore

see #602.

kaikoga avatar Sep 29 '24 09:09 kaikoga