Brian Dukes

Results 177 comments of Brian Dukes

@v-karbovnichy this branch now has conflicts, and the maintainers haven't been given access to make changes to the branch, so we can't merge this PR. Please merge these changes with...

Consider using [the latest version of the new deploy client](https://github.com/EngageSoftware/Dnn.Platform/releases/tag/v10.0.0-bulk-install.67.103263) and see if you get any further insights into the error.

Would it work to have MSBuild just call `yarn run client-build`, rather than needing to use an environment variable?

These images were introduced in https://github.com/dnnsoftware/Dnn.Platform/pull/5692, looks like some of the URLs are invalid

@dnnsoftware/approvers I've rebased on `develop`, should be good to merge.

Just thinking about this PR, should we call the new abstraction `IThemeService`?

I think we can merge this PR as-is. I opened [a new PR](https://github.com/GerardSmit/Dnn.Platform/pull/1) to discuss the potential naming change.

@mitchelsellers would your experience tell you that continuing to run dependent scripts after an error is less likely to leave the site in an unrecoverable state than stopping after an...

Could we add some opt-in attributes to the script component to run scripts fail-fast and/or in a transaction?

Can the provider check for that exclusion and add it if it's missing (on app start, when it's enabled)? I'm also okay with adding it all of the time, I...