Benjamin Drung

Superset of all_timezones/common_timezones is hardcoded

2

On Debian-based systems (including Ubuntu) pytz is patched to use the tzdata information from the system. That allows updating tzdata without needing to update pytz every time. The superset of...

Do not re-compress compressed kernel modules and firmware files

2

Ubuntu ships the kernel modules and firmware files zstd compressed. Dracut puts those compressed files in the initramfs and compresses the cpio archive containing them. Please put compressed kernel modules...

Many shellcheck complains

4

Running `make syncheck` on Ubuntu 24.04 on the source code shows a lot of shellcheck complains, including: * SC2086 (info): Double quote to prevent globbing and word splitting. * SC2317...

Support exit with failure in case a test environment is unsuitable

2

In the Debian/Ubuntu package I want to run all test cases and explicitly disable test that are not suitable. Tests that are skipped because `test_check` fails should fail the test...

crashdb: make _duplicate_db_sync_status more readable

1

Coverity 2023.9.2 rule COV_PY_COPY_PASTE_ERROR_PYTHON complains about `real_fixed_version` in `CrashDatabase.duplicate_db_fixed` looks like a copy-paste error. For the "crash got reopened" case, `real_fixed_version` is `None` and therefore the call to `duplicate_db_fixed` sets...

ui: refactor suppress evaluation in parse_argv

1

Coverity 2023.9.2 rule COV_PY_FORWARD_NULL_PYTHON complains about accessing a property of null-like value "cmd". Refactor the code to satisfy Coverity.

report: Fix possible None.startswith() call

1

In `Report._gen_stacktrace_top` `fn` might be set to `None` and calling `fn.startswith` will fail in that case.

launchpad: fix dynamic adaption of chunck size

1

The chunk size in `HTTPSProgressConnection.send` starts with 1024. The chunk size is checked for being bigger than 1024 before increasing or decreasing it. Therefore this condition will never met and...

apt_dpkg: split _search_contents into smaller methods

1

Split `__AptDpkgPackageInfo._search_contents()` into smaller methods to make the code more readable and modifiable. I did this refactoring to find the test failure, but then I found the failure elsewhere: https://github.com/canonical/apport/pull/310

apt_dpkg: retry on HTTP 429 'Too Many Requests'

4

Running the system tests on different releases in parallel can cause some tests of `test_packaging_apt_dpkg` fail: ``` __________________ test_install_packages_dependencies[deb822] __________________ [...] apport/packaging_impl/apt_dpkg.py:1326: SystemExit ----------------------------- Captured stderr call ----------------------------- ERROR: Package...