FluidNC icon indicating copy to clipboard operation
FluidNC copied to clipboard

strncasecmp function fix

Open bberkhin opened this issue 3 years ago • 3 comments

function strncasecmp does not work correctly, so unit tests fail

bberkhin avatar Jan 06 '22 09:01 bberkhin

Whoa you just saved me a lot of work, because this was exactly the intention of how I started this x86 support branch (and I didn't knew that you can use conio like this)! I'm actually surprised that it works with candle with just these changes.

I did an extensive review, and nagged about the things that I could find. One thing that is a bit of an issue, is that you targetted the 'main' branch instead of the 'devt' branch in the PR (which means we cannot take it as-is without breaking git), but tbh I don't think it will be a lot of trouble cherry-picking the code and re-target it.

I would very much like to have these remaining things fixed so we can get this in the main branch. If you have any questions or remarks, feel free to do so, or just join us on Discord.

atlaste avatar Jan 07 '22 19:01 atlaste

great that you liked my work ) I will re-target all changes to devt branch today or tomorrow and will send a new pull requsts. Coud you send me an invitation do Discord. My id: "Boris Berkhin#3986"

bberkhin avatar Jan 09 '22 06:01 bberkhin

@bberkhin https://discord.gg/aKAT4Dfb

readeral avatar Jan 09 '22 09:01 readeral