Brandon Liu

Results 553 comments of Brandon Liu

This doesn't actually work once you factor in map rotation, unless the rotation is available through the Style Spec.

Some more detail about what this would look like in practice: When post-processing the places layer we have access to other data in memory, we can use that data to...

@nvkelso yeah, that could work too! Otherwise we would need some weighting algorithm - probably based on position relative to water bodies

The only official leaflet style for protomaps vector layers is the one in the source code at https://github.com/protomaps/protomaps.js/tree/main/src/default_style - you can copy or fork this as you like. This repository...

Thinking out loud: ## protomaps-themes-base * It would be generally useful to have a set of basemap styles that is shared among both the protomaps.js canvas renderer and the GL...

@nvkelso I don't think there is still any solve for what you described like tilezen `sort_key` because of intersections? https://github.com/maplibre/maplibre/discussions/164#discussioncomment-4925345 So we need have 4 levels, say 5 road classes,...

@wipfli what if styles weren't embedded in the properties, but you had a single layer for all classes, and the paint properties were a (very big) case statement? So a...

So if we designed around the constraint that there are no variation in linecaps or dashes, we can get away with the total set of ~8 road layers I listed...

Looking at tag info for stats: https://taginfo.openstreetmap.org/keys/layer#values 96.99% of `layer` tags are `-1`, `0` or `1`. We can try a hybrid approach of @wipfli 's for the other 3.01% where...

A style can already support an arbitrary # of layers by using data-driven `line-color` to visually distinguish each `layer`. This looks a bit weird aesthetically, and using casings is better...