Brandon Liu

Results 553 comments of Brandon Liu

store the encoding type in the `compression` key in the metadata JSON, otherwise for type `pbf` you don't know without inspecting the bytes (magic number)

You're right, `compression` as a row in the metadata table not JSON. Does QGIS assume the `pbf` is gzip-encoded?

> faster fnv1a checksum algorithm In tippecanoe we needed a content hash that had the smallest implementation to inline, unsure how the speed compares to md5, but if you need...

We can expose a `setId` method on `Feature`, alongside the existing `getSourceId`. That would provide a Profile-facing API to set the MVT id, but to make it useful we would...

#514 should be all that is needed for setting sourceID (not sure about tile features yet); the actual construction of a feature ID from OSM IDs can be something like...

With the addition of `setId` on `FeatureCollector` I think this issue can be closed on planetiler-core - the specific format of integer feature IDs is left up to the specific...

maybe it's safer to use WKB instead of WKT? Wouldn't writing WKT transform floating-point representation into fixed-precision text; if it's parsed back into floating-point later it might be a different...

Another class of exception from the same run: ``` ERR [archive:encode] - Caught error postprocessing features natural {x=562 y=727 z=11} org.locationtech.jts.geom.TopologyException: found non-noded intersection between LINESTRING ( -0.000000000000000000000000000000007607423280329582 165.08210678118655, -0.000000000000000000000000000000003803711640164791...

We want a separate out-of-band check on the output tileset to check for self-intersection JTS silently creates - my preference is to use https://github.com/mapbox/wagyu

Attached are text files with the full WKT and WKB inputs along with stack traces for the 6 exceptions from last night's build: [exception_6.txt](https://github.com/onthegomap/planetiler/files/13219615/exception_6.txt) [exception_5.txt](https://github.com/onthegomap/planetiler/files/13219616/exception_5.txt) [exception_4.txt](https://github.com/onthegomap/planetiler/files/13219617/exception_4.txt) [exception_3.txt](https://github.com/onthegomap/planetiler/files/13219618/exception_3.txt) [exception_2.txt](https://github.com/onthegomap/planetiler/files/13219619/exception_2.txt) [exception_1.txt](https://github.com/onthegomap/planetiler/files/13219622/exception_1.txt)