Brandon Liu

Results 553 comments of Brandon Liu

Hi @vkrause , 1. Do you only one one update a day, with a daily diff from planet.openstreetmap.org ? 2. Are there read transactions that may be happening at the...

What if you implement reader/writer mutual exclusion, by having the reader acquire the same lock like this: https://github.com/protomaps/OSMExpress/blob/master/utils/osmx-update#L17 If your application can accept reads being blocked for as long as...

Is the convention for Nix packages to use dynamic linking instead of static? I have preferred doing as much static linking as possible because it makes my own builds easier....

If you comment out most of the `include_directories` https://github.com/protomaps/OSMExpress/blob/master/CMakeLists.txt#L23 then CMake should look for headers in your system header paths like /usr/local/include, /usr/include, etc I believe. It may be easier...

+1, should be doable by: 1. bring in the s2 bindings 2. use the s2 region coverer on your input geometry 3. traverse the cell index based on prefix of...

> Can I pass the cell id I get back from RegionCoverer directly to the osmx bindings Index class? Yes, if your coverer has both minimum and maximum cell levels...

> Is the name argument to pass to Index constructor the same as the lmdb table names, e.g. cell_node? I think `cell_node` should work the same way as the other...

Looks good so far! some random thoughts, some directly related and some more speculative: > Correctly generate LineString or Polygon for ways (currently always a LineString) > Relation support This...

I agree that the bindings not being pip installable is an issue, thanks for figuring out the workaround. Were you able to accomplish the goal of your script in an...

https://gist.github.com/CloudNiner/e5552aaae6c235193b8f196558b92e2c#file-osmx_utils-py-L23 This can be made even faster :) as is, on line 23, if you are traversing a cell at a low level, I think you are potentially issuing millions...