fluent_ui icon indicating copy to clipboard operation
fluent_ui copied to clipboard

Separated TextBox Decorations

Open hassony105 opened this issue 1 year ago • 4 comments

Separates TextBox Decorations into:

1- focusedDecoration 2- unFocusedDecoration 3- focusedForegroundDecoration 4- unFocusedForegroundDecoration

Bocuse the color of the TextBox ForegroundDecoration border color changes only from Theme or changing the whole Border, so i have made a changes on the Whole decorations in the TextBox.

For Your Knowledge: I don't know why I did this pull request maybe I was drunk maybe I was sleepy

hassony105 avatar Dec 11 '23 08:12 hassony105

Hello! Thank you for this pull request.

I like the idea of having a different decoration for different states, but the way you proposed is a bit limiting. It'd be nice to have it like buttons do: with a ButtonState.

TextBox(
  decoration: ButtonState.all(BoxDecoration(
    ...
  )),
)

bdlukaa avatar Dec 20 '23 14:12 bdlukaa

do you mean that you want me to replace these:

focusedDecoration unFocusedDecoration

focusedForegroundDecoration unFocusedForegroundDecoration

with ButtonState<BoxDecoration> decoration, ButtonState<BoxDecoration> foregroundDecoration ?

hassony105 avatar Dec 21 '23 06:12 hassony105

yes! what do you think?

bdlukaa avatar Dec 21 '23 13:12 bdlukaa

OK, It is a pretty idea. I will do it.

hassony105 avatar Dec 23 '23 09:12 hassony105