fluent_ui icon indicating copy to clipboard operation
fluent_ui copied to clipboard
verified publisher icon bdlukaa

NavigationPane positioning

Open Arenukvern opened this issue 3 years ago • 1 comments

Pre-launch Checklist

With this PR I would like to add an option for NavigationPane right positioning. Thank you for your time and review!

This doesn't include changes from https://github.com/bdlukaa/fluent_ui/pull/366#issue-1244324932

  • [x] I have updated CHANGELOG.md with my changes
  • [x] I have run "dart format ." on the project
  • [x] I have added/updated relevant documentation
  • [x] I have updated Example accordingly

Arenukvern avatar May 23 '22 19:05 Arenukvern

I like the thing on the Settings screen :)

Altough, I don't like the result of it. Try the RTL mode (scroll to the bottom on settings), I believe that's how it should look like when the position is set. Instead, all the buttons aren't inverted as they should be. The animation is also off: if you check, the name (on the top left) is moved alonside the panel.

bdlukaa avatar May 24 '22 23:05 bdlukaa

@bdlukaa Hello! Happy New Year) Sorry, I thought that this PR is closed as doesn't meet guidelines of MS Fluent UI:) and just wanted to update outdated code:).

The reason why I started making the right side position is because it is convenient mode (in my opinion) for Excel Addins - the web apps, that can be used inside excel - please see example in this repository

So if you think it is useful to include it to your Fluent UI library please let me know, I will work to add RTL support and fixes for your review comments.

Arenukvern avatar Jan 14 '23 08:01 Arenukvern