fluent_ui icon indicating copy to clipboard operation
fluent_ui copied to clipboard

Minor: simplification of example.

Open ignatz opened this issue 2 years ago • 2 comments

I'm new to fluent_ui and as I was reading through the example I found it to be slightly harder to follow than necessary. These are my suggestions to streamline the initial exposure. Nothing much of substance.

EDIT: I also took the liberty to include footer items into the auto suggestions.

Pre-launch Checklist

  • [ ] I have updated CHANGELOG.md with my changes
  • [x] I have run "dart format ." on the project
  • [ ] I have added/updated relevant documentation

ignatz avatar Jan 30 '24 12:01 ignatz

It took me three days to figure out how the home page works. The main issue with this demonstration is the duplicated information required by the go_router and pane_items. One possible solution is grouping navgation prompting, routing and page building together. By supplying builders for either go_router or pane_item, the reduction of total complexity could have been archive.

hunt978 avatar Feb 04 '24 10:02 hunt978

Hey @hunt978 , I did notice and appreciate that part too. That said, I didn't dare to change that part. I wasn't sure if that was maybe intentional to demonstrate the use of gorouter as a popular package :shrug:

ignatz avatar Feb 04 '24 11:02 ignatz