Ben Dilday comments

Results 15 comments of


                                            Ben Dilday

pitching_stats and batting_stats not returning all data

you may need to set `qual=0`? i.e. https://github.com/jldbc/pybaseball/issues/410#issuecomment-2067572318

pitching_stats and batting_stats not returning all data

I think `None` is not the same thing as `0` in this context. You have to set `qual=0`, example, ``` In [10]: batting_stats(2023, end_season=None, league='all', qual=None).loc[:, ["PA"]].describe() Out[10]: PA count...

fixed lahman.py; added test_lahman.py

there is also a fix here https://github.com/jldbc/pybaseball/pull/434 I think there's a preference to avoid relying on 7-zip and `py7zr`?

fixed lahman.py; added test_lahman.py

I meant this PR https://github.com/jldbc/pybaseball/pull/435

cachetools exceptions when reading table metadata

> thanks for reporting this. > > cachetools was introduced [here](https://github.com/apache/iceberg-python/commit/6b7f07a3815349297f765c919f8fa170c2c4562b#diff-e9df836e263024ba54e2706853fb25c00269fbfe3726b440ba57f4a929c995dcR626) and hasn't changed since 0.8.0 > > > Note that we are using multithreading and this might be a...