Bradley Dice
Bradley Dice
Before reading Vyas’s reply above, I had the exact same opinions on organization and functionality. (Maybe we work together too closely. 🤔) I strongly support his proposal above. This would...
I would propose: - Leave `CorrelationFunction` and all other spatial correlation functions (RDF) in the `density` module. - The proposed `correlation` module should be reserved for temporal correlations (between frames)....
@scmartin What weighting function do you have in mind? The function is used in the C++ internals, so you'd need a way to express that Python function in C++. If...
Another way to implement this would be to use a custom `NeighborList` object with the `weights` set to your desired values, and have an option for `weighted=True` that reads from...
@yuanzhou0827 Let me know if you have questions about this PR!
@yuanzhou0827 Have you used this feature in your research? If so, we should try to finish and merge it. If you haven't used this feature in your research then I...
@yuanzhou0827 I just did a merge commit (c1d032a) so this PR is up to date with the latest changes in freud. If you'd like to finish it, just pull those...
Sorry, bumped the close button. I was trying to comment. If you update/move the requirements files first, dependabot will close or recreate the corresponding PRs for new versions. You won’t...
This is a frequently requested feature. I think it could be in scope for freud, but I would strongly recommend implementing it in C++ if it is included in the...
@vyasr and I have discussed this before. I’m on the same page about caution near “sharp edges.” I think it would be fine if the limits to the method are...