Bradley Dice

Results 313 comments of Bradley Dice

Update: I am skipping pytest on Windows, and settling for making `import freud` succeed work with a repaired wheel first. I added a repair command using delvewheel and it now...

This is still a draft, I'm just trying to update GitHub's changeset view. 😕

@vyasr Is this issue only a symptom of a wider problem around normalizing accumulated data? We've discussed this a bit before but haven't really handled it well yet. Looking at...

@vyasr I recommend that we move forward by raising an error if the number of equivalent orientations change without resetting, as you did in #619. In this case, I think...

@vyasr Does this need to be API-breaking? I'd prefer to just handle a third option for `normalize` instead of creating a new argument named `normalization_mode`. Then `True` and `False` would...

Sounds like a good plan. We can list all values / replacements in the DeprecationWarning to make it clear.

@AlainKadar Please resolve any comments that have been addressed and then re-request my review with the 🔁 icon once docstrings are added. Thanks!

Good idea. We should continue to use quaternions in freud's APIs, for alignment with HOOMD's representation of a body rotation, but improving the docs on how to use vector inputs...

In addition to explaining the use of quaternions and how to compute those from vectors, we could also try to improve the docs on what `u` represents. (See [past freud-users...

It looks like all these errors are from differences in single precision handling of the input data. I would relax all of these tests to a lower precision. It seems...