Bradley Dice

Results 313 comments of Bradley Dice

@cbkerr It looks like this PR may need to be updated a bit. It appears to have commits from #181. It might be that this is in a problematic state...

> There is still a problem where it runs the endpoint `notes_update` as many times as there are instances of the Notes module. This problem relates to registering the module...

@cbkerr Ping - just checking to see if you have thoughts about the registration problem. Do you think this is a blocker? Or should we merge this PR regardless, and...

Removing review requests due to inactivity.

Maybe. I’m not categorically opposed to this but dynamically reflowing tiles with a mixed set of sizes will be hard to do in a way that is visually consistent. I...

> just matching prefix (`info-`) might have some unanticipated edge cases. Right, that's why I wasn't sure if this was intended behavior. However, it seems like it's quite a stringent...

This appears to work now! Thank you @dholth.

The build failure shows: ``` /usr/bin/sccache /home/coder/.conda/envs/rapids/bin/x86_64-conda-linux-gnu-c++ -DFMT_HEADER_ONLY=1 -DLIBCUDACXX_ENABLE_EXPERIMENTAL_MEMORY_RESOURCE -DSPDLOG_ACTIVE_LEVEL=SPDLOG_LEVEL_ -DSPDLOG_FMT_EXTERNAL -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_CUDA -DTHRUST_HOST_SYSTEM=THRUST_HOST_SYSTEM_CPP -D_torch_allocator_EXPORTS -I/home/coder/rmm/build/conda/cuda-12.2/release/_deps/cccl-src/thrust/thrust/cmake/../.. -I/home/coder/rmm/build/conda/cuda-12.2/release/_deps/cccl-src/libcudacxx/lib/cmake/libcudacxx/../../../include -I/home/coder/rmm/build/conda/cuda-12.2/release/_deps/cccl-src/cub/cub/cmake/../.. -isystem /home/coder/rmm/include -isystem /home/coder/rmm/build/conda/cuda-12.2/release/_deps/fmt-src/include -isystem /home/coder/rmm/build/conda/cuda-12.2/release/_deps/spdlog-src/include -fvisibility-inlines-hidden -fmessage-length=0 -march=nocona -mtune=haswell -ftree-vectorize -fPIC -fstack-protector-strong...

Can we add a test for this change?

No need to block on tests if existing functionality is untested, but this is a gap that might be worth addressing in the future.