Bradley Dice
Bradley Dice
If I understand correctly, every RAPIDS library would have a different definition of `rmm::device_vector` because it’s reused straight from Thrust. Would those types be interchangeable among RAPIDS libraries using rmm...
Excellent, the common namespace prefix seems to be essential here. However, it makes me wonder if this truly solves any problems (compared with no namespace) because some rmm types (for...
(Thanks for the clarification @robertmaynard / @allisonvacanti! My previous message may have sounded negative on this idea - poor writing on my part.)
@senior-zero Will a tag be made for these changes? Our CPM configuration in cuDF relies on a tag right now. I'd use branch `1.17.X` but I would prefer for the...
> Note, `cupy.from_dlpack` which I use in favour of the deprecated `cupy.fromDLpack` (deprecated in cupy 10) in the tests does not exist in `cupy=9.5`. What's the right way to support...
Agreed. I think the natural separation of API components is more aligned with the docs than the package structure.
This is still relevant. I aim to work on a few more of these ideas after #11296, when I can also move `SparkMurmurHash3_32` out of `hash_functions.cuh`. See also: https://github.com/rapidsai/cudf/pull/11292#discussion_r925887225 edit:...
We should also add documentation to detail methods in `hashing.hpp`.
The [build metrics report](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-cpu-cuda-build/CUDA=11.5/11304/Build_20Metrics_20Report/) for 18bd5e8 appears to indicate that the patch worked. `src/groupby/sort/group_argmax.cu.o` took 14:27 min / 6.877 MB vs. the [previous build metrics report](https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cudf/job/prb/job/cudf-cpu-cuda-build/CUDA=11.5/11269/Build_20Metrics_20Report/) for a454d0e which took...
I have benchmarked commits 7c621d02301745ebae45e60d1a417127dd4ef337 (Thrust 1.17, changes in this PR) and 217243c1c6bbb6ffc39d68c06ec14162daf6d8aa (Thrust 1.15, base). The results are below. **Summary: I don't see anything too significant or worrisome resulting...