smartelectronix icon indicating copy to clipboard operation
smartelectronix copied to clipboard

Fix changed URL for VSTSDK

Open etheory opened this issue 4 years ago • 1 comments

NOTE: this PR is incomplete and needs more work, but it's definitely heading in the right direction.

Please someone else check that this works for them, but it sure works for me! Except something isn't quite right, as after this I get a build error:

[cmake] Cannot find source file: [cmake] [cmake] ..../smartelectronix/Steinberg/public.sdk/source/vst2.x/audioeffect.cpp

Which looks like it's due to the new folder: vstsdk2 sitting above public.sdk so the build scripts need to be changed to reflect this....

I tried manually editing smartelecronix/Common/common.cmake with the new paths, but it didn't help.

Even doing that doesn't fix it since aeffect.h doesn't exist in the new SDK. @bdejong any ideas?

etheory avatar Nov 29 '21 02:11 etheory

Linked to: https://github.com/bdejong/smartelectronix/issues/49

etheory avatar Nov 29 '21 02:11 etheory

Thanks for merging @bdejong but did you note the issue I commented on in the PR above where this now doesn't build? Did you manage to fix that? This PR wasn't yet complete.

etheory avatar Jun 26 '23 20:06 etheory

It wasn't building before either... I prefer to merge and then fix the things that need fixing.

For the Steinberg headers etc I think I will just pull them into the repository rather than trying to download them.

bdejong avatar Jun 27 '23 10:06 bdejong