feat(contributePopup): added a contribute popup every 10 questions

Open ayoubqrt opened this issue 3 years ago • 4 comments

What this PR is about?

Related to #15. New feature : Added a little popup to propose the user to contribute on this project every 10 questions (link to this github)

Oct 24 '22 23:10 ayoubqrt

I could not see the popup appears and I don't see the code part that would make it appears. Also, can you create a storybook story so that we can see the popup component in the design system? Thank you for this pr that is well needed! I'm excited to see the design of the popup!

Oct 25 '22 08:10 bdebon

My bad!! I was not testing the good PR !!

Oct 25 '22 08:10 bdebon

on small device, not sure about the position of the popup: CleanShot 2022-10-25 at 10 11 14@2x

And can you still create the story in storybook so we can refine the design of this popup more easily ? Clicking 10 images to see it coming can be a lot of work just to check a design :)

Oct 25 '22 08:10 bdebon

Oh yes, I have never used storybook so I didn't have the reflex to put my component in it. For the small devices I know that is very ugly, have you a idea for the position of the popup ? The height/width images are flexible based on the votes rate and putting a popup in small devices is not easy as I expected ... Maybe I can do a small button with just a icon and the user can click on it and after we can see the message.

I will think about a new design for the popup also. I imagine that you have not been excited as expected in your first message 😆.

Oct 25 '22 09:10 ayoubqrt