William Deegan

Results 323 comments of William Deegan

> > is the file in your real code a target for a builder? > > @bdbaddog, yes. See line 283 in https://github.com/platformio/platformio-core/blob/develop/platformio/builder/tools/piobuild.py#L264:L304 > > Users in PlatformIO do not...

> I don't see why a node should not have a link back to its env if we know how to set it. A single assignment should not be that...

> Would you have created such a node by calling `env.File()`? Seems unlikely, but will bow to your experience Nope. But that's not the issue. New users seem to think...

ParseDepends above is a work around. Pull request #3053 implements a fuller scanner which should handle the above fully.

> Updating the set of related issues. Yes, the `CConditionalScanner` handles the specific case stated here. > > Since not every compilation system would behave the same way trying to...

> I have no idea how you invoke msvc to spit out header dependencies, I'm not saying it can't. /showIncludes but it goes to stdout while running the compiler.

I'd say hold off on any more work on this until we determine if anything breaks if we remove including child nodes contents in get_contents().

Honestly it should do neither. The node's children shouldn't be added into it's contents. The scanner/taskmaster should check that the children of the Value() are out of date or not.....

`MSVC_PREVIEW=True`.. let's not encourage old logic.. ;)