William Deegan
William Deegan
Looks good to me, commit the change?
Please add a RELEASE/CHANGES.txt blurb. @mwichmann & @jcbrill - do we need any doc updates here? Any functional changes not covered by docs?
You do realize if that: `env.MSVSProject(..., MSVS_PROJECT_GUID='unique to this builder call') ` Will yield that builder getting it's own unique MSVS_PROJECT_GUID (via the OverrideEnvironment() which is always created when a...
There's no projectguid in the manpage, only MSVS_PROJECT_GUID, so that should be the variable name used. I think you're still missing my point about OverrideEnvironment() ``` env = env=Environment(tools=['msvs'], MSVS_VERSION...
But you were asserting `For multiple projects, this would assign the same GUID to both projects:` indeed that's true with the code, but you can specify any envvar as extra...
@jcbrill - it's in the docs that you can do this. you can specify CPPPATH, LIBS, LIBPATH,etc to Program(), etc.. https://scons.org/doc/production/HTML/scons-user.html#builder_overrides
Sorry if you're taking offense here, it seemed like you weren't aware that this was standard practice (to override or specify env vars to builders in the builder call)..
@jcbrill - I don't think MSVSSolution/Project are a widely used feature, especially with VariantDirs. And even less SCons developers use those.. so I'm to terribly suprised that the solution isn't...
> Since another change is required... > > **Do we want to skip the "loopy" (i.e., iterates over all msvc versions and not a snarky commentary on the msvs tool...
@jglezplatas - Please fill in the issue template information above.