William Deegan

Results 323 comments of William Deegan

Does the default scanner do ifdefs? or is it just the optional scanner which does?

@managan - https://github.com/SCons/scons/wiki/GitWorkflows

Any chance you can hop on discord to discuss? https://discord.gg/bXVpWAy

My alteration to the reproducer and a patch: [90f7fbc253c9363648191227850059b6-f1bf47c613a7988942294926131a1327a6f25249.zip](https://github.com/SCons/scons/files/4283671/90f7fbc253c9363648191227850059b6-f1bf47c613a7988942294926131a1327a6f25249.zip) It looks like minimally ListAction() doesn't propagate the batch_key for the Action(s). (The included patch resolves this, though it may not...

See https://github.com/bdbaddog/scons-bugswork/tree/main/4282 for a downloadable example

Sample Stacktrace: ``` TypeError: Directory /work/mongo/build/debug/mongo/tools/mongobridge found where file expected.: File "/work/mongo/SConstruct", line 5558: env.SConscript( File "/work/mongo/src/third_party/scons-3.1.2/scons-local-3.1.2/SCons/Script/SConscript.py", line 597: return _SConscript(self.fs, *files, **subst_kw) File "/work/mongo/src/third_party/scons-3.1.2/scons-local-3.1.2/SCons/Script/SConscript.py", line 286: exec(compile(scriptdata, scriptname, 'exec'),...

The original filer is using `glob.glob('*.cpp')` which doesn't guarantee order staying the same between runs... That could have something to do with this..

The original filer is using `glob.glob('*.cpp')` which doesn't guarantee order staying the same between runs... That could have something to do with this.. I've imported the zip file and updated...

Not exactly sure what's the issue. Here's the generated command line which get's run (after my changes.. I moved variant_dir to the SConscript call so the variantdir wasn't a child...