William Deegan
William Deegan
It looks like Variables.instance is a class variable and thus is a singleton. Am I reading that wrong?
> The only note would be that using `tarfile` module leaves the work being done in-process, which is not necessarily the best choice if there's lots going on and many...
While this solution works, I'm not sure if specifying a list of directories of which only the first one is handled differently is the best solution? If there's includepaths, and...
The comment is wrong I believe. and predates setting those values elsewhere... if I remember correctly.
@mwichmann sounds right. Maybe check if the passed action is a child of `ActionBase` or a string, or a list of strings or action bases, or a function with the...
> There are other Python projects that do this better, for example [rdiff-backup](https://pypi.org/project/rdiff-backup/). Thanks for the pointer, we'll take a look at how they do it. https://github.com/rdiff-backup/rdiff-backup/blob/master/pyproject.toml
Right. It used to be a thing, but hasn't been for a long time. Safe to assume that most project do not ask for this any more right?
I beleive the example was such, but the intent was it would preserve any symlinks.
@mwichmann - we'd likely have to add an envar, something like `INSTALL_COPY_SYMLINKS` or such?
hmm. if you had to specify `vars=Variables(use_shell_env=True)` to pick them up from the shell environment, that might be ok?