IMGW telemetry dataset

[bczernecki]

Downloading IMGW-PIB measurements from telemetry system

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 89 lines in your changes missing coverage. Please review.

Project coverage is 78.13%. Comparing base (9c168a6) to head (28326f9). Report is 2 commits behind head on master.

:exclamation: Current head 28326f9 differs from pull request most recent head 15446f9

Please upload reports for the commit 15446f9 to get more accurate results.

Files	Patch %	Lines
R/meteo_imgw_datastore.R	0.00%	74 Missing :warning:
R/meteo_imgw_telemetry_stations.R	0.00%	15 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   82.46%   78.13%   -4.33%     
==========================================
  Files          30       32       +2     
  Lines        1608     1697      +89     
==========================================
  Hits         1326     1326              
- Misses        282      371      +89     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[Nowosad]

No internet connection:

══ Skipped tests (5) ═══════════════════════════════════════════════════════════
• empty test (5): 'test-hydro_metadata_imgw.R:7:1',
  'test-meteo_imgw_daily.R:11:1', 'test-meteo_noaa_co2.R:1:1',
  'test-nearest_stations_noaa.R:1:1', 'test-nearest_stations_ogimet.R:3:1'

══ Warnings ════════════════════════════════════════════════════════════════════
── Warning ('test-meteo_metadata_imgw.R:5:3'): tests to be re-written meteo_metadata_imgw ──
cannot open file '/tmp/RtmpaEp3Fu/working_dir/RtmpqYw3MW/fileeed1343621da': No such file or directory
Backtrace:
    ▆
 1. └─climate:::meteo_metadata_imgw("hourly", "synop") at test-meteo_metadata_imgw.R:5:2
 2.   └─climate:::clean_metadata_meteo(...)
 3.     └─base::readLines(temp, warn = FALSE)
 4.       └─base::file(con, "r")

══ Failed tests ════════════════════════════════════════════════════════════════
── Error ('test-meteo_metadata_imgw.R:5:3'): tests to be re-written meteo_metadata_imgw ──
Error in `file(con, "r")`: cannot open the connection
Backtrace:
    ▆
 1. └─climate:::meteo_metadata_imgw("hourly", "synop") at test-meteo_metadata_imgw.R:5:2
 2.   └─climate:::clean_metadata_meteo(...)
 3.     └─base::readLines(temp, warn = FALSE)
 4.       └─base::file(con, "r")
── Failure ('test-meteo_ogimet.R:44:3'): meteo_ogimet works! ───────────────────
`meteo_ogimet(...)` did not throw an error.
── Failure ('test-meteo_ogimet.R:58:5'): meteo_ogimet works! ───────────────────
nrow(multiyr) > 70 is not TRUE

`actual`:   FALSE
`expected`: TRUE 

[ FAIL 3 | WARN 1 | SKIP 5 | PASS 25 ]

[Nowosad]

This should be fixed before sending to CRAN.

[Nowosad]

Also: there is a typo in DESCRIPTION: "Meterology" (wow)

[Nowosad]

This typo is also in README (and maybe a few other places...)

[bczernecki]

IMHO it's ready for re-review @Nowosad :)

[Nowosad]

@bczernecki, a few comments:

1. meteo_imgw_telemetry_stations -> stations_meteo_imgw_telemetry (as in stations_ogimet)
2. The warning below should be suppressed:

library(climate)
telemetry_stations = meteo_imgw_telemetry_stations()
#> Warning in FUN(X[[i]], ...): NAs introduced by coercion

[bczernecki]

telemetry_stations = meteo_imgw_telemetry_stations()

corrected in the most recent commit