bcoin icon indicating copy to clipboard operation
bcoin copied to clipboard

getTxByAddress options missing from client

Open pinheadmz opened this issue 4 years ago • 2 comments

See https://bitcoin.stackexchange.com/questions/95524/bcoin-io-get-txs-in-reverse-order

Options object should be added here:

https://github.com/bcoin-org/bcoin/blob/6beb54dddc1256cca379ad765b71fd5cdee427f3/lib/client/node.js#L110-L113

pinheadmz avatar Apr 26 '20 22:04 pinheadmz

The additional options can currently be included using client.execute, client.get and etc.

Querying complete results using after hasn't been added to the CLI or client, either. I've recently needed to support that, and used client.get, see https://github.com/braydonf/bcoin/blob/acct/bin/bcoin-acct-cli#L98-L109 This could probably be wrapped in an interface to either stream or iterate the result, so as to not overload memory. The CLI could stream the complete results to stdout.

braydonf avatar Apr 27 '20 20:04 braydonf

@pinheadmz Is this issue still active?

ShivamJhaa avatar Jan 30 '23 02:01 ShivamJhaa