bcash icon indicating copy to clipboard operation
bcash copied to clipboard

[rpc] add initialblockdownload to getblockchaininfo

Open dagurval opened this issue 6 years ago • 3 comments

Mimics the initialblockdownload added to getblockchaininfo in https://github.com/bitcoin/bitcoin/pull/11258.

I couldn't find a IBD estimator in the bcash codebase. This is probably not a good check for IBD status, but it's only supposed to be an estimate anyway.

dagurval avatar Feb 22 '19 23:02 dagurval

Codecov Report

Merging #131 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   55.55%   55.55%           
=======================================
  Files         109      109           
  Lines       27184    27184           
  Branches     4498     4498           
=======================================
  Hits        15102    15102           
  Misses      12082    12082
Impacted Files Coverage Δ
lib/node/rpc.js 22.54% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update faf1eeb...d556632. Read the comment docs.

codecov-io avatar Feb 22 '19 23:02 codecov-io

<= 0.99 might be ok, but also note if there hasn't been a block in about 40 minutes, bcoin will start to show progress as < 1:

https://github.com/bcoin-org/bcoin/blob/f585d8616df8335fddbc21d1b776a979ec6ff305/lib/blockchain/chain.js#L2116-L2126

pinheadmz avatar Feb 22 '19 23:02 pinheadmz

<= 0.99 might be ok, but also note if there hasn't been a block in about 40 minutes, bcoin will start to show progress as < 1:

https://github.com/bcoin-org/bcoin/blob/f585d8616df8335fddbc21d1b776a979ec6ff305/lib/blockchain/chain.js#L2116-L2126

I put the numbers in a sheet and as you can see this doesn't seem to be an issue.

screenshot from 2019-02-23 22-16-48

dagurval avatar Feb 23 '19 21:02 dagurval