Benjamin E. Coe

Source map remapping has issues on files with no branches or functions

16

I noticed this error cropping up for HTML reports:

fixing off by one error in reporting causes exceptions for othe reports

1

``` TypeError: Cannot read property 'loc' of undefined at /Users/bencoe/google/nodejs-phishing-protection/node_modules/istanbul-reports/lib/lcovonly/index.js:53:35 at Array.forEach () ```

There's a slight hiccup with merging logic that was brought to my attention [here](https://github.com/bcoe/c8/issues/66). https://user-images.githubusercontent.com/1324510/52922996-26a90980-3360-11e9-907c-6fa464fec932.png Here's the output that we're failing to process appropriately: ```json { "scriptId": "61", "url": "file:///Users/benjamincoe/bcoe/c8/foo.js",...

@eugeneo points out there may be path weirdness in Windows (see: https://github.com/nodejs/node/pull/17360) we should get some tests around this.

merge with istanbul-lib-hook

1

istanbul-lib-hook, and append-transform have similar functionality; I think we should figure out how to merge the two. istanbul-lib-hook has the added advantage that it handles hooking into the `vm.createScript` method:...

errors when .sh script run with shim

2

I finally dug into the problem that @boennemann is seeing here: https://github.com/bcoe/nyc/issues/34 tldr; this script fails when instrumented with spawn-wrap's shim: https://github.com/semantic-release/semantic-release/blob/caribou/test/registry/start.sh The logic that is causing the script to...

@sofisl @billyjacobson the [following PR](https://github.com/googleapis/nodejs-local-auth/pull/62) shows that our automated code generation reverts a couple of the changes made to move us away from using the `master` branch name. The GitHub...