Keep the test suite on the tags ?

[tenzap]

I noticed that although the test suite (tests/ directory) is present on the git branches, they are not kept on the tags. So when checking out a tag, we actually don't have the test suite

$ git log 3.1.13

commit bcb17eb8ba53a85de154439d0ab8ff1bed047bc9 (tag: 3.1.13)
Author: Andrey Andreev <[email protected]>
Date:   Thu Mar 3 15:21:49 2022 +0200

   [ci skip] 3.1.13 release

commit 2042929bab8ffc14faf6193de0107b7f95abbdaf (upstream/master)
Author: Andrey Andreev <[email protected]>
Date:   Thu Mar 3 15:09:04 2022 +0200

   [ci skip] Doc updates for 3.1.13 start and changelog entry for #6107

And in the bcb17eb8ba53a85de154439d0ab8ff1bed047bc9, all test suite is removed

Would it be possible to keep the test suite also on the tags?

[gxgpet]

Why would you need this?

[tenzap]

Because when building Debian packages, the test suite of the software is run. So it is better if it is shipped by upstream. It is recommended to have the test suite while building the package. And the test suite in not in any of the deliverables (neither tarball, nor tags). This could also be useful to find packages on Debian that would not run on upcoming php versions for exemple when transitioning from php8.2 to php8.3. There are probably other use cases.

Usually php composer packages don't ship the test suite in the tarball, but it is available on the tags. In that case, when updating the sources we get it from git tag instead of the tarball.

[rgson]

How come the tags are created separately from the branches and with different content?

I think tagging off-branch makes it difficult to e.g. apply a security patch to a particular version too. I can't easily tell what the tagged version corresponds to on the branches and how far behind it is, and I can't run the test suite on the patched code.