CodeIgniter icon indicating copy to clipboard operation
CodeIgniter copied to clipboard

set_cookie: foreach not consistent with preceding comment

Open rwalkerands opened this issue 3 years ago • 0 comments

Commit eb770fdc6d809bc7c28d499f897c0ab2c449f669 added the $samesite parameter to set_cookie(). But now there's a contradiction between the foreach and the comment on the immediately preceding line (system/core/Input.php lines 311-312):

  // always leave 'name' in last place, as the loop will break otherwise, due to $$item
  foreach (array('value', 'expire', 'domain', 'path', 'prefix', 'secure', 'httponly', 'name', 'samesite') as $item)

Either the comment or the code is wrong ....

rwalkerands avatar Sep 13 '22 06:09 rwalkerands