CodeIgniter icon indicating copy to clipboard operation
CodeIgniter copied to clipboard

Add optional parameter to like(), or_like(), not_like() and or_not_like() methods.

Open nalakapws opened this issue 6 years ago • 5 comments

This PR address the 2nd feature request from this #5641 issue.

nalakapws avatar Nov 27 '18 13:11 nalakapws

This is parameter creep ... It may look inconsistent, but a better option would be to just have having_like(), having_not_like(), etc.

And you must follow the styleguide.

narfbg avatar Dec 12 '18 22:12 narfbg

You're still ignoring the styleguide ...

narfbg avatar Dec 17 '18 07:12 narfbg

Is there anything I have to do in order to make this PR get merged?

nalakapws avatar Jan 02 '19 02:01 nalakapws

Yes, there are still some spaces left in on lines 1100, 1171 (shown in diff with darker green).

And there's more significant stuff code-wise, but it will probably result in a lot of back and forth if I asked you to do all of it, so I can make those changes myself after merging. It's decent enough as it is, I just want less repetition.

narfbg avatar Jan 04 '19 13:01 narfbg

Yes, all of CodeIgniter doesn't match PSR-2 rules. We have our own styleguide, referenced in the contributing guide, which you should read before reviewing others' work.

narfbg avatar Feb 28 '19 14:02 narfbg